Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clang-tidy] Vote: Add exception checks #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

j-stephan
Copy link
Collaborator

Voting will close on 13 September 2023 EOD HZDR time.

  • bugprone-exception-escape: - Link
  • bugprone-throw-keyword-missing: - Link
  • cert-err58-cpp - Link
  • cert-err60-cpp - Link
  • hicpp-exception-baseclass - Link
  • misc-throw-by-value-catch-by-reference - Link
  • modernize-use-noexcept - Link
  • modernize-use-uncaught-exceptions - Link

Vote template

Check | Yes | No | Comment
------|-----|----|--------
`bugprone-exception-escape` | X | X | X
`bugprone-throw-keyword-missing` | X | X | X
`cert-err58-cpp` | X | X | X
`cert-err60-cpp` | X | X | X
`hicpp-exception-baseclass` | X | X | X
`misc-throw-by-value-catch-by-reference` | X | X | X
`modernize-use-noexcept` | X | X | X
`modernize-use-uncaught-exceptions` | X | X | X

Vote

Check Yes No Comment
bugprone-exception-escape 1 0 -
bugprone-throw-keyword-missing 1 0 -
cert-err58-cpp 1 0 -
cert-err60-cpp 1 0 -
hicpp-exception-baseclass 1 0 -
misc-throw-by-value-catch-by-reference 1 0 -
modernize-use-noexcept 1 0 -
modernize-use-uncaught-exceptions 1 0 -

@bernhardmgruber
Copy link
Collaborator

All in favor! cert-err58-cpp may hit us in some places, but I think it's better to disable it locally and still see the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants